Reduce the CI Warnings and Errors to 0/0

[alexstyl]

Short Description

Static analysis was recently added to the project (#141). Initially the project contained a lot of issues that were pointed out by the analysis. Because of that some threshold was added to the warnings and errors so that it would not be a blocker for further development.

Ideally, the threshold should be 0 errors and 0 warnings (0/0), so that future new issues are identified before being introduced to the code base.

Running static analysis on your machine

Open the terminal at the directory of the root of the project and run

./gradlew check

The configuration files you need to check in order to modify the thresholds are:
team-props/static-analysis/detekt-config.yml and
team-props/static-analysis.gradle