Refresh the sample app #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt version of the build tools that the plugin specifies. - remove test runner - sample app does not have any tests - update dependencies
- rename compose function to follow compose naming convention - remove lint warnings - add experimental annotation for Coil - sort contacts in descending order by "isStarred" - to imitate original Google contacts application
alexstyl
requested changes
Jan 4, 2022
sample/src/main/java/com/alexstyl/contactstore/sample/ContactListViewModel.kt
Outdated
Show resolved
Hide resolved
|
@tatocaster I saw you pushed some changes. Everything looks good from my end, but I am not sure if you are done with your changes. Are you happy for me to merge? |
|
At this moment, yes 🚀 This PR is completely related to the sample app. I will merge it immediately when you approve Thanks for the quick response 🙏 |
alexstyl
approved these changes
Jan 4, 2022
|
@alexstyl looks like, you need to merge those changes 🙌 I do not have the permission |
|
Merged. Thanks again for the contribution @tatocaster :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildToolsVersion- the project automatically uses a default version of the build tools that the plugin specifies. docs