Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in header contain index.php #127

Closed
thijslemmens opened this issue Feb 24, 2016 · 1 comment
Closed

Links in header contain index.php #127

thijslemmens opened this issue Feb 24, 2016 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@thijslemmens
Copy link
Contributor

The 1.0 version used links like:
href="backend/settings"

Now this has become:
href="/index.php/backend/settings"

Is there a good reason to do that?

Shouldn't you use site_url('backend/settings') ?

I'm not writing a lot of php, and I'm not familiar with CodeIgniter, that's why I'm ask. I'm happy to send in a pull request with the fix if you confirm I am correct.

By the way, I just upgraded, and my URL's containing index.php if I click around. I'm using an NGINX config instead of .htaccess and a subfolder.

@alextselegidis
Copy link
Owner

Actually you're definitely right. It was supposed to be like that but I didn't know about the URL helper back then and the site_url method so this is why I've written that manually.

I will mark this as an enhancement and give you the time to integrate it within the application.

Thanks for noticing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants