Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with Fresco DraweeView#getController() method #25

Open
caojianfeng opened this issue Feb 29, 2016 · 6 comments
Open

Conflict with Fresco DraweeView#getController() method #25

caojianfeng opened this issue Feb 29, 2016 · 6 comments

Comments

@caojianfeng
Copy link

I want create a class like this

class ReaderCellView extends DraweeView implements GestureView{
//...
}

but both DraweeView and GestureView has function getController()
and the return type is different.

And I think it is better to make the function of a Interface as special as we can.

@caojianfeng
Copy link
Author

can we use getAlexGestureController as the name of the function ?

@alexvasilkov
Copy link
Owner

Yeah, it's sad that Fresco uses same method name. The only workaround I can suggest right now is to attach source code of this library and change method's name to whatever you like.

I will consider this issue in next major release, but it will not be very soon unfortunately.

@caojianfeng
Copy link
Author

Thank you very much!

@alexvasilkov
Copy link
Owner

Thanks for your feedback, I will keep it open until I'll find a good way to fix it.

@alexvasilkov alexvasilkov reopened this Mar 4, 2016
@alexvasilkov alexvasilkov changed the title conflict with facebook DraweeView on function name Conflict with Fresco DraweeView#getController() method Mar 18, 2016
@Droppers
Copy link

Droppers commented Nov 8, 2017

Hi @alexvasilkov,

Is there any update on this?

@alexvasilkov
Copy link
Owner

I'm planing to implement this as part of future 3.x.x version since it requires breaking changes.
But I still can't share any specific date when it will be released.

Meanwhile I would suggest to use Glide or something similar if you want to use this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants