Timezone format (12/24hr) not used

[ShaneF1]

V1.0.6

A minor issue but the timezone format is not used when displaying ETA. If the system is configured to use 24hr format, the plug-in still displays 12hr format.

[AlexVerrico]

Hi @ShaneF1
This is on the roadmap for the project, but probably for a few months. Just to confirm, you have your pi set to 24hr time?

[ShaneF1]

After setting TZ using "sudo dpkg-reconfigure tzdata" the local time is displayed in 24hr format. Is there a better way to do it?

[AlexVerrico]

I will have to do a bit of research about this, because I have the exact opposite situation, that is, I have set my time to display in 12hr format, but the ETA is displayed in 24hr format, so something clearly isn't right with with how we are setting the time display format, or with how the plugin finds out what format to use.

[ShaneF1]

From my reading (I'm a python novice), this might benefit from the addition of ",get_locale()" in line 35 __init_py:

strtime = format_time(finish_time,get_locale())

[AlexVerrico]

Hi @ShaneF1
Thanks for the suggestion.
I have added that to the development branch, but can't test it for a couple of days, if you would like to assist in testing, you can install the updated version from here: https://github.com/AlexVerrico/Octoprint-Display-ETA/archive/devel.zip
Cheers,
Alex.

[ShaneF1]

No, that didn't work. It gets tied up in a dependency chain which I don't have the experience to debug. For the moment I have hardcoded my time format.

strtime = format_time(finish_time,'HH:mm:ss')

[joshuacant]

My ETA time is also shown in 24h format even though I have run the tzdata reconfigure and picked a time zone that should be 12h (USA EDT). Perhaps a setting to toggle between the two formats would give people the control, rather than trying to determine it automatically, especially when a lot of people might never bother setting it correctly.

[AlexVerrico]

Hi everyone.
As of version 1.1.0 you can now configure this on the settings page for the plugin in Octoprint.
Cheers,
Alex.