Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site command does not trim punctuation, so generated links are incorrect. #3

Closed
JERisBRISK opened this issue Feb 10, 2022 · 0 comments · Fixed by #11
Closed

site command does not trim punctuation, so generated links are incorrect. #3

JERisBRISK opened this issue Feb 10, 2022 · 0 comments · Fixed by #11

Comments

@JERisBRISK
Copy link
Collaborator

JERisBRISK commented Feb 10, 2022

The current logic hyphenates card names to convert them to parallel URLs. E.g.:

!site "Archivist's Pride"
https://parallel.life/cards/archivist’s-pride

However, the URL is incorrect and results in a 404. It should be:
https://parallel.life/cards/archivists-pride/

Another example is Soleia:

!site "soleia, disciple of gaffar"
https://parallel.life/cards/soleia,-disciple-of-gaffar

URL should actually be:
https://parallel.life/cards/soleia-disciple-of-gaffar/

Another example is GRAUL

!site "G.R.A.U.L." (note, the trailing period is incorrect, issue #5 addresses that)
https://parallel.life/cards/g.r.a.u.l.

URL should actually be:
https://parallel.life/cards/graul

@JERisBRISK JERisBRISK changed the title site command does not trim apostrophes, so generated links are incorrect. site command does not trim punctuation, so generated links are incorrect. Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant