Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed go2rtc in an application #1030

Open
webfrank opened this issue Apr 4, 2024 · 2 comments
Open

Embed go2rtc in an application #1030

webfrank opened this issue Apr 4, 2024 · 2 comments
Labels
question Further information is requested

Comments

@webfrank
Copy link

webfrank commented Apr 4, 2024

Hi, I would like to embed go2rtc in a custom go application. All modules are internal and it is not possible to start the required modules.

Is there any way to accomplish this?

@AlexxIT AlexxIT added the question Further information is requested label Apr 5, 2024
@AlexxIT
Copy link
Owner

AlexxIT commented Apr 5, 2024

Base and core modules are public

@nicpottier
Copy link

FWIW I have the same problem. I want to extend go2rtc in Go but because you can't start the components as they are in internal you can't really short of forking it. Given go2rtc is an app not a library it feels overkill to use the reserved internal namespace as it basically forces anybody wanting to extend it to fork the repo.

I totally get you don't want to have to guarantee any kind of API compatibility though and Go does want you to use versioning for that but again, as an app I am not entirely sure that applies.

In any case it's fine, if I end up going that route I will probably fork /rename and rebase occasionally. Just figured I would leave a comment here to say Frank is not alone. Thank you for all the work you do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants