feat(plate): adds new prop "warning" for type #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IBelyaev
requested review from
Arver1,
aweppc,
dmitrbrvsk,
SiebenSieben and
stepancar
Luchanso
approved these changes
Apr 15, 2020
dmitrbrvsk
approved these changes
Apr 15, 2020
prosto-lapsha
approved these changes
Apr 15, 2020
stepancar
reviewed
Apr 15, 2020
src/plate/plate.css
Outdated
| @@ -37,6 +37,12 @@ | |||
| border: 1px solid rgba(13, 186, 38, 0.2); | |||
| } | |||
|
|
|||
| &_type_warning { | |||
| /* TODO rgba-цвета заменить на переменные */ | |||
| background-color: rgb(255, 249, 240); | |||
There was a problem hiding this comment.
А почему сейчас не написать нужные цвета из переменных?
stepancar
approved these changes
Apr 16, 2020
src/plate/plate.css
Outdated
| &_type_warning { | ||
| /* TODO rgba-цвета заменить на переменные */ | ||
| background-color: rgb(255, 249, 240); | ||
| border: 1px solid rgba(249, 211, 150, 0.2); |
There was a problem hiding this comment.
Сделай, пожалуйста, так:
background: rgba(246, 191, 101, 0.1)
border-color: rgba(246, 191, 101, 0.6)
Это --color-sand 0.6 и 0.1, ещё нет в переменных, решают
SiebenSieben
approved these changes
Apr 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавляет новое состояние для компонента, а именно
propотвечающий заbackground-colorиborder-colorМотивация и контекст
Ссылка на макет
https://www.figma.com/file/NDAzQX1HYAJ2NtQQHNo4LDLs/NIB-Components?node-id=38%3A22