feat(calendar): add component propery to fix calendar height #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadBrozzeR
requested review from
SiebenSieben,
stepancar,
Poletay and
SkripalBoris
|
Я за то чтоб опции не было. Потому что миграцию нужно организовывать, кто этим займется - не понятно |
|
Убрал опцию, обновил упавший снапшот. |
SiebenSieben
approved these changes
Apr 29, 2020
added 2 commits
April 30, 2020 11:27
…fa-laboratory/arui-feather into feature/fixed-calendar-height
reme3d2y
approved these changes
Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Зафиксирована высота календаря (по факту в календаре просто всегда становится шесть недель).
Плюс немного поправлены предупреждения от линтера в рамках дорабатываемого файла.
Мотивация и контекст
Если календарь открывается во всплывающем окне с фиксированной нижней границей, то из-за варьирующейся высоты календаря при перелистывании месяцев с помощью UI стрелок, кнопки постоянно уходят из-под курсора.