feat(client): fix import and hover for input theme #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RG100-EMUX
reviewed
Dec 19, 2020
| @@ -2,16 +2,23 @@ | |||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| @import "@alfalab/core-components-vars/colors-bluetint.css"; | |||
| @import "../vars.css"; | |||
| @import "~@alfalab/core-components-vars/colors-bluetint.css"; | |||
There was a problem hiding this comment.
не очень понимаю, почему в темной теме импорт с тильдой, а в светлой без?
RG100-EMUX
approved these changes
Dec 21, 2020
SiebenSieben
approved these changes
Dec 21, 2020
FenkoAlex
reviewed
Dec 21, 2020
src/input/input_theme_alfa-dark.css
Outdated
|
|
||
| .input_theme_alfa-dark { | ||
| .input__box { | ||
| .input__box, | ||
| .input__box:hover { |
There was a problem hiding this comment.
не понимаю зачем это нужно, тебе при ховере надо в другой цвет бордер покрасить? почему ты добавил box-shadow?
Suggested change
| .input__box:hover { | |
| .input__box { | |
| &:hover { | |
| border-bottom-color: var(--color-dark-graphic-primary); | |
| } |
этого будет достаточно, разве нет?
FenkoAlex
approved these changes
Dec 21, 2020
FenkoAlex
added a commit
that referenced
this pull request
May 27, 2021
* feat(theme): add new theme * feat(theme): add theme to heading, link, plate * feat(theme): add new theme type * feat(theme): add some themed icons * feat(theme): revert icons * feat(theme): fix * feat(client): add new themes for input component (#1240) add input theme * feat(*): add new themes for button (#1243) * feat(*): add new themes for button * fix(package.json): fix peerDependencies Co-authored-by: Лукин Валерий Николаевич <vlukin@alfabank.ru> * feat(theme): fix lint * feat(theme): fix input * feat(client): fix import and hover for input theme (#1244) fix input * feat(theme): add paragraph and label * feat(client): add new theme for tabs and tab-item (#1247) add tabs * feat(*): add new themes for label and notification (#1248) add notification * feat(*): add new themes for list, fix import styles heading (#1250) add list * Update src/input/input_theme_alfa-dark.css Co-authored-by: Igor Maslov <ethorz.ru@gmail.com> * Update src/input/input_theme_alfa-light.css Co-authored-by: Igor Maslov <ethorz.ru@gmail.com> * feat(theme): add special arui-demo version * feat(theme): add body dark theme * feat(theme): update css * feat(theme): update Plate and Button * feat(*): add themes for checkbox&checkbox-group&tag-button (#1261) * feat(*): add themes for checkbox&checkbox-group&tag-button * fix(*): fix code style * fix(*): fix css for icons * fix(*): update package-lock Co-authored-by: Лукин Валерий Николаевич <vlukin@alfabank.ru> * feat(theme): fix test * feat(theme): try fix lint * feat(theme): fix mistake * feat(theme): fix ts compile * feat(theme): fix gemini * Feat/new theme components (#1260) * fix(client): add transparent and filled states * feat(client): add new theme for select * feat(client): add textarea and input-autocomplete * feat(*): add new themes and fix button hover state * feat(theme): fix lock-file Co-authored-by: Alex Fenko <afenko@alfabank.ru> * feat(*): add new themes for radio&radioGroup (#1263) Co-authored-by: Лукин Валерий Николаевич <vlukin@alfabank.ru> * feat(*): add new themes for sidebar (#1264) Co-authored-by: Лукин Валерий Николаевич <vlukin@alfabank.ru> * feat(client): add new theme for calendar (#1262) * feat(client): add new theme for calendar * feat(client): add new theme for calendar Co-authored-by: Alex Fenko <afenko@alfabank.ru> * feat(theme): fix gemini * feat(theme): up version * fix(client): padding for select and popup border (#1265) * feat(select): update select * feat(calendar): update calendar * feat(attach): update attach * fix(input): fix clear icon * fix(popup): del shadow * fix(link): fix link border color (#1271) * fix(link): fix link border color * fix(link): fix hovered & focus link color in alfa-white * fix(calendar): fix selected calendar day style in dark theme (#1272) * added box-shadow to popup elements in theme-dark (#1276) * fix(*): fix input styles for dark and color theme (#1278) * WIP: fix gemini tests (#1283) * fix(*): fix attach and button component * fix(*): fix components before sidebar * feat(test): update gemini BREAKING CHANGE Co-authored-by: Alex Fenko <afenko@alfabank.ru> Co-authored-by: PoytaL <76110903+PoytaL@users.noreply.github.com> Co-authored-by: Valeryi Lukin <48721141+Atcad@users.noreply.github.com> Co-authored-by: Лукин Валерий Николаевич <vlukin@alfabank.ru> Co-authored-by: Igor Maslov <ethorz.ru@gmail.com> Co-authored-by: Nadezzdi <48017468+Nadezzdi@users.noreply.github.com> Co-authored-by: Nadine <nsyakovleva@alfabank.ru> Co-authored-by: SNosenko <81819609+SNosenko@users.noreply.github.com> Co-authored-by: Aleksandr Dyuzhikov <alex.duzh@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Мотивация и контекст
Исправление импорта переменных в файлах с темами и добавление перекрытия стандартных стилей компонента.