feat(attach): add progress bar #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiebenSieben
approved these changes
Oct 24, 2019
Heymdall
approved these changes
Oct 24, 2019
stepancar
reviewed
Oct 24, 2019
There was a problem hiding this comment.
@sklyanchuk @Heymdall @SiebenSieben а вот такие штуки не хотим заворачивать в один объект?
Или в данном случае вобще можно понять undefind или нет в progressBarPercent и понять показывать или нет
вообще согласен, если можно обойтись одним пропсом, то лучше так и сделать. |
|
Согласен, в данном случае лучше обойтись одной пропсой |
SiebenSieben
approved these changes
Oct 25, 2019
stepancar
approved these changes
Oct 26, 2019
|
Да, gemini хорошо бы, добавил в бэклог |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Отслеживание процесса загрузки файла через индикатор выполнения (progress bar).
Мотивация и контекст
Я как пользователь, загружая тяжелый файл, хочу понимать, в каком состоянии сейчас загрузка моего файла и сколько мне, предположительно, ждать окончания загрузки.