Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding inputs option for "Search:" label #17

Merged
merged 2 commits into from Jan 15, 2014
Merged

Adding inputs option for "Search:" label #17

merged 2 commits into from Jan 15, 2014

Conversation

LouWii
Copy link
Contributor

@LouWii LouWii commented Dec 16, 2013

Hi !

I'm using dynatable for my website and I just saw that the label "Search:" near the search field is not easily changeable.

So I create an option, just like you did at first, to modify the label.

I tested it just now and it's working great.

I hope it will fill your requirements.

Thank you for your work.

Added an input option to modify the "Search:" label near the search field.

Added an input option to modify the "Search:" label near the search field.
@brandondrew
Copy link

👍
Yes, I think this is very useful. For example, I prefer "Filter" for manipulation of data that is already downloaded to the browser, and "Search" when you're searching a database or some data source that is not already onscreen or otherwise in your browser. So being able to change the term is in my opinion very helpful for usability.

@byrnecore
Copy link

+1

I actually removed it and added it within the input as a Placeholder attribute.

Something worth considering too.

:)

@JangoSteve
Copy link
Member

Awesome, thanks for this. I'm actually working on a slightly more encompassing fix for this, but this looks good in the meantime. I just wanted to make sure quick that you read the contributing guidelines and are cool with them, and I can pull this right in.

@LouWii
Copy link
Contributor Author

LouWii commented Dec 18, 2013

I read and I agree with the contributing guidelines :)

I think that the record count has to be changeable too.

recordCountField: 'Showing {x} to {y} out of {z} records',
filteredRecordCountField: 'Showing {x} of {y} records (filtered from {z} total records)'

Or something like that. It would make the display totally and easily customisable.

@JangoSteve
Copy link
Member

Yeah, this has also been mentioned in #8. It will work almost exactly like what you have when I finish implementing the input templating functionality for #9.

@JangoSteve
Copy link
Member

Can you amend your commit to add a space after "Search:"?

@LouWii
Copy link
Contributor Author

LouWii commented Dec 19, 2013

I hope that I done that well (I'm not so comfortable with the use of github).

@JangoSteve JangoSteve merged commit f203a57 into alfajango:master Jan 15, 2014
@JangoSteve
Copy link
Member

Thanks for this! I merged it in, but I renamed searchFieldText to just searchText to be a bit more concise and more consistent with the other configuration names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants