Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce cognitive complexity of ChainedMethodInvocationRefactor#handleMethodInvocation and use only one break or continue statement #104

Closed
RadikalJin opened this issue May 20, 2022 · 4 comments · Fixed by #105
Closed

Reduce cognitive complexity of ChainedMethodInvocationRefactor#handleMethodInvocation and use only one break or continue statement #104

RadikalJin opened this issue May 20, 2022 · 4 comments · Fixed by #105
Assignees
@mohannaidu
Labels
good first issue Good for newcomers

Comments

@RadikalJin
Copy link
Member

See https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=alfasoftware_astra&open=AYDiEpr_kKZeZDp5nkOu
and https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=alfasoftware_astra&open=AYDiEpr_kKZeZDp5nkOt
@RadikalJin RadikalJin added the good first issue Good for newcomers label May 20, 2022
@mohannaidu
Copy link

can you assign this issue to me? let me have a go at it

@mohannaidu
Copy link

i managed to fix the first issue. looking at the second sonar issue

@RadikalJin
Copy link
Member Author

Hey @mohannaidu! Sure, I’ll assign this to you now.

@mohannaidu
Copy link

Create a PR. Please review and let me know if any changes required.

@mohannaidu mohannaidu mentioned this issue May 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohannaidu mohannaidu

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/issue 104 reduce cognitive complexity mohannaidu/astra
2 participants
@mohannaidu @RadikalJin