Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the lock_an_unlock() test doesn't report failures #4

Open
fabricedesre opened this issue Oct 5, 2022 · 2 comments
Open

the lock_an_unlock() test doesn't report failures #4

fabricedesre opened this issue Oct 5, 2022 · 2 comments

Comments

@fabricedesre
Copy link

It looks like failures in the forked child are not preventing the test from passing. You can reproduce that by adding assert!(false) in the child branch of fork() at

let mut locked = false;

@fabricedesre fabricedesre changed the title the lock_an_unlock() test doesn't catch failure the lock_an_unlock() test doesn't report failures Oct 5, 2022
@alfiedotwtf
Copy link
Owner

Thanks for the report. I'll take a look on the weekend

@alfiedotwtf
Copy link
Owner

Sorry for the long delay...

Yep, you're right. The parent process should be checking if the child exited cleanly. But looking at the code, a lot of Rust has changed since 2015! We at least have cargo fmt...

I think what I'll do is sometime soon I'll block out some time and rewrite and reformat these tests (and I guess the whole crate).

Thanks again, and thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants