Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor paypal callback controller #644

Closed
syjer opened this issue May 11, 2019 · 1 comment
Closed

refactor paypal callback controller #644

syjer opened this issue May 11, 2019 · 1 comment
Assignees
@syjer
Labels
enhancement public website
Milestone
2.0-M2

Comments

@syjer
Copy link
Member

syjer commented May 11, 2019

see: https://github.com/alfio-event/alf.io/blob/master/src/main/java/alfio/controller/payment/PayPalCallbackController.java

currently we save the PayPalToken in session, which is kinda ugly:

session.setAttribute(PaymentManager.PAYMENT_TOKEN, new PayPalToken(payPalPayerID, payPalPaymentId, hmac));

Move the token in the reservation metadata.
@syjer syjer added this to the 2.0-M2 milestone May 11, 2019
@syjer
Copy link
Member Author

syjer commented Jul 3, 2019

done in PR #674

@syjer syjer closed this as completed Jul 3, 2019
@syjer syjer self-assigned this Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syjer syjer

Labels
enhancement public website
Projects
None yet
Milestone
2.0-M2
Development

No branches or pull requests
1 participant
@syjer