Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove support for ENABLE_CAPTCHA_FOR_OFFLINE_PAYMENTS #646

Closed
syjer opened this issue May 29, 2019 · 1 comment
Closed

remove support for ENABLE_CAPTCHA_FOR_OFFLINE_PAYMENTS #646

syjer opened this issue May 29, 2019 · 1 comment

Comments

@syjer
Copy link
Member

syjer commented May 29, 2019

Note, it depend on #588.

We will deprecate and remove the code path that handle the recaptcha for the case ENABLE_CAPTCHA_FOR_OFFLINE_PAYMENTS .

We think that ENABLE_CAPTCHA_FOR_TICKET_SELECTION (recaptcha enabled at the ticket selection phase) is better and simpler.
@syjer syjer added the breaking change This issue will introduce a breaking change label May 29, 2019
@syjer syjer added this to the 2.0-M2 milestone May 29, 2019
@syjer syjer removed the breaking change This issue will introduce a breaking change label Jul 19, 2019
@syjer syjer removed this from the 2.0-M2 milestone Jul 19, 2019
@syjer
Copy link
Member Author

syjer commented Jul 19, 2019

note, this task will not be done.

@syjer syjer closed this as completed Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@syjer