Remove panic on missing candidates

[thomaseizinger]

The following panic can be triggered if the IceAgent is being fed "wrong" data:

str0m/src/ice/agent.rs

Lines 1166 to 1168 in eb0fbe0

	.expect(
	"STUN request for socket that is neither a host nor a relay candidate. This is a config error.",
	)

I'd argue that we should remove this panic and instead just drop the message. This can for example be triggered if the IceAgent is not configured with a host candidate but only with srflx candidates. I don't really see why that wouldn't be valid?

Generally, I don't think we should ever panic if the user hands us bad socket addresses or data within Receive / StunPacket. I'd prefer if we log a warn! and drop the packet. We are after all exposed to network traffic here and should gracefully handle whatever is thrown at us.

[algesten]

Yeah, agree. Panic is a bit much. Dropping the packet seem reasonable.

[algesten]

This has been addressed right?

[thomaseizinger]

This has been addressed right?

Nope! Not as far as I know.