-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Power9 support #671
Comments
Ring is a transitive dependency for ureq that comes from "rustls". What's sad is that rustls is built despite you using ureq/native-tls. This is because Rust's feature flags are additive, so if dependency A says "ureq with rustls" and B says "ureq with native-tls", we get an indeterminate TLS backend. We have instead opted for compiling both and making deciding which to use runtime. This decision is biting us here, because you simply can't get it to NOT compile rustls on Power9 despite it not being used. I'm sorry to say there isn't a quick fix we can do here. We're already using the latest rustls release, and the Power9 build must be fixed in the rustls project. Changing the feature flag behavior would be a breaking change and require a major release. I promise I'll monitor the rustls project to keep us tightly up-to-date, but the feature flag behavior is something we need to take with us into consideration for making a new major version in the future (it's the first time I encountered this). My only suggestion is to stay on the previous version of ureq, for now. |
Thanks Martin. |
I'm trying to build pgrx from source on Debian 12 on power9.
It fails on the ring.0.16.02 crate because that version does not support power9.
This has been fixed in the newest version (ring.0.17.2 or 3)
According to the pgrx team:
Looks like our dependency on ring is transient through our dependency on ureq (for cargo-pgrx). Also looks like our default is to use ureq/native-tls.
Would it be possible for you to update your dependancy tree?
The text was updated successfully, but these errors were encountered: