Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge devwithmain into dev #17

Merged
merged 33 commits into from Sep 5, 2021
Merged

Conversation

angelofallars
Copy link
Collaborator

Changes

  • Convert tabs into spaces
  • Fix formatting of function parameters

Original:

second_entry = tk.Entry(root, font = ("Arial", 24)
		, textvariable = second, width = 5
		, fg = "#C72C41", bg = "#510A32"
		, justify="center", bd = "0")

Updated:

second_entry = tk.Entry(root, font=(FONT, FONT_SIZE_ENTRIES),
                        textvariable=second, width=5,
                        fg=ENTRY_FOREGROUND, bg=ENTRY_BACKGROUND,
                        justify="center", bd="0")
  • Overhaul the variable names to fit Pythonic conventions (Timing to timing)
  • Refactor all repeated variables into their own constants for easier changing (Font, font size, background color, foreground color)
# Constants
TITLE = "PomoDrip"
FONT = "Arial"
BACKGROUND = "#2D142C"
ENTRY_FOREGROUND = "#C72C41"
ENTRY_BACKGROUND = "#510A32"
FONT_SIZE_ENTRIES = 24
FONT_SIZE_TODO = 12
  • Group all function definitions together in code
  • Put the main code into a main() function
  • Add docstrings for all functions
  • Add support for command-line arguments
  • Todo list must be specifically enabled from the command-line with the argument --todolist

Command-line arguments

python3 main.py --help displays the help text of the program:

usage: pomodrip [--todolist]

PomoDrip is a tkinter-based Pomodoro Timer written in Python.

OPTIONS:
     --todolist   Enable a todo-list (EXPERIMENTAL)


Report bugs to https://github.com/algodrip/pomodrip/issues

To activate the todo list, type python3 main.py --todolist.

Copy link
Contributor

@ryanamay ryanamay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally daijobu

@ryanamay ryanamay merged commit fc39f24 into algodrip:Dev Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants