ignorePlurals: accept a list of ISO codes #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoErcolanelli
force-pushed
the
ignorePlurals-langs
branch
from
5f8fd4b
to
5ce81cc
Compare
LeoErcolanelli
force-pushed
the
ignorePlurals-langs
branch
from
5ce81cc
to
3a92ce8
Compare
ElPicador
approved these changes
Nov 9, 2016
| @@ -0,0 +1,6 @@ | |||
| package com.algolia.search.objects; | |||
|
|
|||
| public class Get { | |||
There was a problem hiding this comment.
I would rename it IgnorePlurals
| package com.algolia.search.objects; | ||
|
|
||
| public class Get { | ||
| public static class Boolean {} |
There was a problem hiding this comment.
I would more something like
interface IgnorePlurals {}
class IgnorePluralsList extends IgnorePlurals {}
class IgnorePluralsBoolean extends IgnorePlurals {}
But with better names
eunjae-lee
pushed a commit
that referenced
this pull request
Mar 3, 2022
eunjae-lee
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ElPicador Is this what you were expecting? I used a class with inner classes to avoid creating multiple
.javafiles, but that may be clearer than this.