New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapper and namespace #1

Closed

fulmicoton opened this issue May 28, 2013 · 1 comment

fulmicoton commented May 28, 2013

It seems like the AlgoliaSearch object is the only public API and that
AlgoliaUtils_* are just internal functions.

If this is the case, algoliasearch might benefits from a (function() {...})() wrapper in order to avoid global namespace pollution.

In addition, AlgoliaUtils_stringifyParamValues does not actually seems to be called anywhere.

Member

speedblue commented May 29, 2013

You are right, I removed AlgoliaUtils_stringifyParamValues and removed all functions in global namespace.
Thanks for the comment.

speedblue closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment