Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(personalization): deprecate client-recommendation #1278

Merged
merged 4 commits into from Jun 23, 2021
Merged

feat(personalization): deprecate client-recommendation #1278

merged 4 commits into from Jun 23, 2021

Conversation

francoischalifour
Copy link
Member

@francoischalifour francoischalifour commented Jun 17, 2021 •
edited by Haroenv

This PR targets the feat/recommend base branch.

Description

We want to remove mentions of the old Recommendation API to avoid any confusion with the new Algolia Recommend product.

This deprecates the @algolia/client-recommendation package and migrates it to @algolia/client-personalization.

Changes

  • Deprecate client-recommendation exports in TSDoc
  • Add a depreciation warning when createRecommendationClient is called
  • Update the endpoint from recommendation.us.algolia.com to personalization.us.algolia.com
  • Add initPersonalization to algoliasearch and deprecate initRecommendation

fixes #1281

What's next

  • Deprecate the npm package @algolia/client-recommendation in the Recommend release

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 17, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e965655:

Sandbox Source
javascript-client-app Configuration

Haroenv
Haroenv reviewed Jun 17, 2021
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! one place where it can possible be a bit simpler maybe?

packages/algoliasearch/src/builds/browser.ts Show resolved Hide resolved
@francoischalifour francoischalifour merged commit 03bd1a2 into feat/recommend Jun 23, 2021
@francoischalifour francoischalifour deleted the feat/client-personalization branch June 23, 2021 08:31
francoischalifour added a commit that referenced this pull request Jun 23, 2021
@francoischalifour
feat(recommend): introduce Recommend API client (#1280)
97ebde6 
feat(recommend): introduce Recommend API client

feat(personalization): deprecate client-recommendation (#1278)
@shortcuts shortcuts mentioned this pull request Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

@shortcuts shortcuts Awaiting requested review from shortcuts

Assignees
No one assigned
Labels
Scope: Recommend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@francoischalifour @Haroenv