Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add abTestID to SearchResponse #1419

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

shortcuts
Copy link
Member

Summary

Ticket: https://algolia.atlassian.net/browse/CR-1581

Fixes #1418

Add abTestID field to the SearchResponse type.

@shortcuts shortcuts self-assigned this Jul 27, 2022
@shortcuts shortcuts enabled auto-merge (squash) July 27, 2022 07:16
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7164221:

Sandbox Source
javascript-client-app Configuration

@shortcuts
Copy link
Member Author

Looking at https://www.algolia.com/doc/api-reference/api-parameters/getRankingInfo/#impact-on-the-response it's a bit confusing if it's under _rankingInfo or at the root, we've put it at the root in v5 which makes sense as it's bound to abTestVariantID, wdyt?

Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing gives me _rankingInfo in the hits and other fields at the root. The doc is indeed not perfectly clear.
Screenshot 2022-07-27 at 09 46 29

@shortcuts shortcuts merged commit 05059f2 into master Jul 27, 2022
@shortcuts shortcuts deleted the fix/searchresponse-params branch July 27, 2022 07:48
@shortcuts
Copy link
Member Author

Yep indeed, I'll add a ticket in our maintenance backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing property "abTestID" in search response TypeScript types
2 participants