Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibilities with Spark because of json4s #363

Closed
redox opened this issue Mar 2, 2017 · 7 comments
Closed

Incompatibilities with Spark because of json4s #363

redox opened this issue Mar 2, 2017 · 7 comments

Comments

@redox
Copy link
Contributor

redox commented Mar 2, 2017

Algolia Scala API client is not compatible with Spark (any version) because of an incompatible version of json4s (Spark#2.0.2 depends on json4s version 3.2.11, Algolia latest client 3.4 and those binaries are incompatible as expressed here). You certainly want to provide an artifact without the json4s dependency or using an older version for Spark compatibility.

cc @framis

@ElPicador
Copy link
Contributor

@framis: I've changed the dependency for json4s, could you tell me if this fixes your issue?

@framis
Copy link

framis commented Mar 2, 2017

Sure, I'll check tomorrow. Thanks!

@ElPicador ElPicador added the bug label Mar 10, 2017
@ElPicador
Copy link
Contributor

@framis were you able to test it?

@framis
Copy link

framis commented Mar 12, 2017

I used com.algolia:scala-client_2.11:1.0.1-SNAPSHOT

I managed to test it (both spark-submit and spark-shell, with Spark version 2.1). Now it compiles, which is better than last time, but I got this exception:

Exception in thread "main" java.lang.NoClassDefFoundError: scoverage/Invoker$
	at algolia.AlgoliaClient.<init>(AlgoliaClient.scala:34)

when trying to do

val client = new AlgoliaClient("MY_APP_ID", "MY_SECRET")

You can find the code I used here: https://github.com/framis/spark-algolia

@ElPicador
Copy link
Contributor

I made a PR on your code, it works for me locally: framis/spark-algolia#1

@framis
Copy link

framis commented Mar 13, 2017

Great! We're good to go, then!

@ElPicador
Copy link
Contributor

Ok I'll merge this and release the new version 1.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants