Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the way to cancel network request #29

Closed
clement-leprovost opened this issue Mar 21, 2016 · 2 comments
Closed

Refactor the way to cancel network request #29

clement-leprovost opened this issue Mar 21, 2016 · 2 comments
Assignees
@clement-leprovost
Labels
enhancement solved
Milestone
v3

Comments

@clement-leprovost
Copy link
Contributor

  • We should be able to cancel any request, not just searches.
  • We should return an object that can be acted upon, rather than providing a separate cancelQueries() method.
  • Caution: think about the synchronous methods.
  • Caution: think about the offline mode.
@clement-leprovost clement-leprovost added this to the v3 milestone Mar 21, 2016
@clement-leprovost clement-leprovost self-assigned this Mar 21, 2016
@clement-leprovost clement-leprovost mentioned this issue Mar 31, 2016
Merged
@clement-leprovost
Copy link
Contributor Author

Implemented in the v3 branch, waiting for release.

@clement-leprovost
Copy link
Contributor Author

Version 3.0 released.

@faresMagdyElsokary faresMagdyElsokary mentioned this issue Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clement-leprovost clement-leprovost

Labels
enhancement solved
Projects
None yet
Milestone
v3
Development

No branches or pull requests
1 participant
@clement-leprovost