-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: autocomplete to alpha.44 #227
Conversation
This is a duplicate of #220 |
I hadn't seen it, but:
Let's release this one to give a workaround to people running the UI on Gatsby? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The clear button has not the correct color when hovered
- The detached input has not the same size
What is the correct color? There is not hover on a touch device anyway.
Yes it's a design choice, to look more like a button I imagine: https://github.com/algolia/autocomplete/blob/next/packages/autocomplete-theme-classic/src/theme.scss#L482 |
Well the bug is still there anyway, correct color could be white idk
it's up to us to decide our own design, and I think it's better if both type of input are the same height no? |
Ok I thought we were talking the Cancel button, this bug was already here and I hadn't retested this part. For the input height, we've already shipped it like that last time and I think it makes sense to have it look like a button since it opens a fullscreen search. One less CSS property to override also. |
Changes
autocomplete-theme-classic
and updated our overriding CSS:Touch
->Detached
), updated or removed (.aa-Panel--desktop
)detachedMediaQuery
to let user control the detached mode (https://algolia-autocomplete.netlify.app/docs/detached-mode/#what-is-detached)How to test