Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BaseWidget): allow declared state and index widgets #825

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jul 29, 2021

Summary

  • BaseWidget needs to explicitly allow IndexWidget as it doesn't technically extend widget anymore
  • BaseWidget needs to allow a generic state, for voice widget (first/only one that actually declares the state)

Result

no type errors on https://github.com/Khbero/sample-app

@Haroenv Haroenv requested a review from tkrugg July 29, 2021 08:09
@netlify
Copy link

netlify bot commented Jul 29, 2021

✔️ Deploy Preview for angular-instantsearch ready!

🔨 Explore the source changes: e48d423

🔍 Inspect the deploy log: https://app.netlify.com/sites/angular-instantsearch/deploys/610262433acf160007bf027d

😎 Browse the preview: https://deploy-preview-825--angular-instantsearch.netlify.app

@Haroenv Haroenv merged commit e46fae7 into v4 Jul 29, 2021
@Haroenv Haroenv deleted the fix/v4-type-errors branch July 29, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants