fix(js): display empty template only with a query

algolia · Feb 11, 2021 · 7c2f9a3 · 7c2f9a3
1 parent 5accc82
commit 7c2f9a3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 17 deletions.
diff --git a/packages/autocomplete-js/src/autocomplete.ts b/packages/autocomplete-js/src/autocomplete.ts
@@ -39,21 +39,6 @@ export function autocomplete<TItem extends BaseItem>(
   const isDetached = reactive(
     () => window.matchMedia(props.value.renderer.detachedMediaQuery).matches
   );
-  const shouldPanelOpen =
-    optionsRef.current.shouldPanelOpen ||
-    (({ state }) => {
-      const hasItems = getItemsCount(state) > 0;
-
-      if (!props.value.core.openOnFocus && !state.query) {
-        return hasItems;
-      }
-
-      const hasEmptyTemplate = Boolean(
-        hasEmptySourceTemplateRef.current || props.value.renderer.renderEmpty
-      );
-
-      return (!hasItems && hasEmptyTemplate) || hasItems;
-    });
   const autocomplete = reactive(() =>
     createAutocomplete<TItem>({
       ...props.value.core,
@@ -65,7 +50,22 @@ export function autocomplete<TItem extends BaseItem>(
         onStateChangeRef.current?.(options as any);
         props.value.core.onStateChange?.(options as any);
       },
-      shouldPanelOpen: isDetached ? () => true : shouldPanelOpen,
+      shouldPanelOpen:
+        optionsRef.current.shouldPanelOpen ||
+        (({ state }) => {
+          const hasItems = getItemsCount(state) > 0;
+
+          if (!props.value.core.openOnFocus && !state.query) {
+            return hasItems;
+          }
+
+          const hasEmptyTemplate = Boolean(
+            hasEmptySourceTemplateRef.current ||
+              props.value.renderer.renderEmpty
+          );
+
+          return (!hasItems && hasEmptyTemplate) || hasItems;
+        }),
     })
   );
   const lastStateRef = createRef<AutocompleteState<TItem>>({

diff --git a/packages/autocomplete-js/src/render.tsx b/packages/autocomplete-js/src/render.tsx
@@ -105,7 +105,7 @@ export function renderPanel<TItem extends BaseItem>(
         </div>
       )}
 
-      {items.length === 0 && source.templates.empty ? (
+      {items.length === 0 && source.templates.empty && state.query ? (
         <div className={classNames.sourceEmpty}>
           {source.templates.empty({
             createElement,