Angular directive name conflicts with autocomplete="off"

[brandonpassley]

Bug 🐞

The Angular directive name conflicts with the HTML autocomplete attribute. When using autocomplete="off" on an input on the same page as the Algolia autocomplete directive, the directive converts the input into an Algolia autocomplete input.

[rayrutjes]

@jerskouille can this be solved with the noConflict method recently introduced? #134

[Jerska]

Unfortunately no. This was a bold move on our end to take an actual HTML attribute as a directive name. This is definitely a bug, but I think it is easily resolvable.
According to MDN, autocomplete itself as an attribute does nothing. It expects a string value.

We're not expecting any value to be passed through the autocomplete attribute, so we can simply check for that.

We also need to take into account that the directive is restricted on Attribute & Class, so for instance:

<input class="autocomplete" autocomplete="off" />

should still be using autocomplete.js.

So in the end, I think we can continue the linking function only

if (element.hasClass('autocomplete') || attrs.autocomplete === '') {
  // ...
}

here to prevent this.

However, funnily enough, I think we're actually setting autocomplete to off afterwards. Definitely confusing.