Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main empty template should be in display:none as long as some sources have results #185

Closed
vvo opened this issue Jun 22, 2017 · 2 comments
Closed
Assignees

Comments

@vvo
Copy link
Contributor

vvo commented Jun 22, 2017

Do you want to request a feature or report a bug?
bug

What is the current behavior?
The main empty template: autocomplete('dsadsa', {templates: empty: 'no results'})) is always displayed even when there are some results. Usually this is not an issue but if you style it like this:

.aa-empty {
  height: 20px;
}

Then it will break your design.

If the current behavior is a bug, please provide all the steps to reproduce and a minimal
JSFiddle example or a repository on GitHub that we can npm install
and npm start.

What is the expected behavior?

The aa-empty template should always be in display: none as long as there are some results.

@redox redox self-assigned this Jun 22, 2017
@redox
Copy link
Contributor

redox commented Jun 22, 2017

A quick fix could be to use autocomplete('dsadsa', {templates: empty: '<div>no results</div>'})) and having the following CSS:

.aa-empty > div {
  height: 20px;
}

@vvo
Copy link
Contributor Author

vvo commented Jun 22, 2017

Yes, I am also creating a proper fix and will release it

@vvo vvo assigned vvo and unassigned redox Jun 22, 2017
@vvo vvo closed this as completed in 344e225 Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants