Throw err on update if suggestions are invalid type #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
reviewed
Oct 9, 2018
test/unit/dataset_spec.js
Outdated
| @@ -80,6 +80,10 @@ describe('Dataset', function() { | |||
| expect(this.dataset.getRoot()).toContainText('empty'); | |||
| }); | |||
|
|
|||
| it('should throw an error if suggestions is not an array', function() { | |||
| expect(this.source.and.callFake(fakeGetNonArrayResults)).toThrow(); | |||
There was a problem hiding this comment.
you can assert some of the text of the array. I forgot if this is Jest or not, but if it is: toThrowErrorMatchingSnapshot()
|
Should this be merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #131
Summary
Throws an error if
suggestionsprovided by a dataset are not valid type (Array). This helps the developer/user understand why results aren't displayed rather than silently failing.