fix(release): Update mversion to 1.12 #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `npm run release` with current stack resulted in the following error for me: ``` /home/tim/.nvm/versions/node/v10.11.0/bin/node[13632]: ../src/node_contextify.cc:628:static void node::contextify::ContextifyScript::New(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[1]->IsString()' failed. 1: 0x8d20d0 node::Abort() [/home/tim/.nvm/versions/node/v10.11.0/bin/node] 2: 0x8d21a5 [/home/tim/.nvm/versions/node/v10.11.0/bin/node] 3: 0x9075f7 node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/home/tim/.nvm/versions/node/v10.11.0/bin/node] 4: 0xb89f5b [/home/tim/.nvm/versions/node/v10.11.0/bin/node] 5: 0xb8bef2 v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [/home/tim/.nvm/versions/node/v10.11.0/bin/node] 6: 0x1a2b66f5c01d Aborted (core dumped) ``` Upgrading `mversion` to 1.12 fixes it.
francoischalifour
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
npm run releasewith current stack resulted in the followingerror for me:
Upgrading
mversionto 1.12 fixes it.