Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing _.every method #274

Merged
merged 6 commits into from
Dec 12, 2018
Merged

fixing _.every method #274

merged 6 commits into from
Dec 12, 2018

Conversation

mlue
Copy link
Contributor

@mlue mlue commented Dec 10, 2018

Previously every was depending on return false to break the forEach loop in order to provide a correct value. angular's forEach does not behave this way. This ensures that _.every provides the right answer no matter what.

fixes #272

@Haroenv
Copy link
Contributor

Haroenv commented Dec 10, 2018

Thanks! Really nice to see your solution here.

Could you remove the dist from the PR itself though? It makes it easier to review

@coveralls
Copy link

coveralls commented Dec 10, 2018

Coverage Status

Coverage decreased (-0.02%) to 88.936% when pulling 0694509 on mlue:fixing_every into 892a8f0 on algolia:master.

@Haroenv
Copy link
Contributor

Haroenv commented Dec 11, 2018

Thanks a lot for this PR. Do you think it would be possible to add a test case which failed with the previous implementation to avoid this ever coming back? Thanks!

@Haroenv Haroenv merged commit 55af1e3 into algolia:master Dec 12, 2018
@mlue mlue deleted the fixing_every branch December 12, 2018 15:23
@mlue
Copy link
Contributor Author

mlue commented Dec 12, 2018

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_.every helper function returns true if last item of collection is true
3 participants