Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rename the assigned variable #346

Merged
merged 1 commit into from Oct 20, 2020
Merged

docs: rename the assigned variable #346

merged 1 commit into from Oct 20, 2020

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Oct 20, 2020

This PR fixes autocomplete = autocomplete( error.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c73e175:

Sandbox Source
@algolia/js-example Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this too and decided not to assign it to any variable in my examples 😂

alternatives:

  • complete
  • autocompleteInstance
  • completions
  • just instance?

@francoischalifour
Copy link
Member

autocompleteSearch is fine.

@eunjae-lee eunjae-lee merged commit 5e80cdd into next Oct 20, 2020
@eunjae-lee eunjae-lee deleted the docs/update-code branch October 20, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants