Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): provide non-minified theme #635

Merged
merged 1 commit into from Jul 23, 2021

Conversation

shortcuts
Copy link
Member

Summary

Users were not able to build create-react-app applications when using the autocomplete theme due to a postcss bug with the minified version. See #626 for more details.

We now provide a non-minified version of the theme as a workaround to prevent this issue.

Result

  • The main file is still the minified version, but is now called theme.min.css
  • The non-minified version is available at @algolia/autocomplete-theme-classic/dist/theme.css

Closes #626

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 69e26ca:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-voice-search Configuration
@algolia/autocomplete-example-vue Configuration

@Haroenv
Copy link
Contributor

Haroenv commented Jul 23, 2021

could also build and then push the output through a minifier, but this is more standalone

@shortcuts shortcuts merged commit ca49d60 into next Jul 23, 2021
@shortcuts shortcuts deleted the feat/provide-non-minified-theme branch July 23, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Algolia Classic Theme does not work with Create React App Webpack configuration
3 participants