feat(pagination): scroll to top on page change #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const { view, ConnectedHit } = useAppContext(); | ||
| const { view, ConnectedHit, topAnchor } = useAppContext(); | ||
|
|
||
| const onPageClick = React.useCallback( |
There was a problem hiding this comment.
We have to memoize functions passed to React InstantSearch components (Pagination here) otherwise it triggers an infinite loop.
| ); | ||
| }); | ||
|
|
||
| function getPaddingLeft(currentPage, padding, maxPages, size) { |
There was a problem hiding this comment.
The below methods are taken from the orignal implementation.
sarahdayan
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This scrolls to top on each page change, which avoids users to scroll back to top manually to scan items.
Changes
I got rid of the
ScrollTocomponent which didn't behave properly, and implemented our ownPaginationcomponent.