fix(searchBox): autofocus input when modal opens #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we switched from React to Preact, the app lost the "autofocus" feature on the input when the modal opens. This happens because [Preact follows the HTML spec](preactjs/preact#1255 (comment)) of triggering the autofocus on page load, and not when the component mounts. React is more "aggressive" on this behavior. This therefore gets rid of the `autoFocus` prop which is ignored here, and focuses the input with an effect. Closes #119.
sarahdayan
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we switched from React to Preact, the app lost the "autofocus" feature on the input when the modal opens.
This happens because Preact follows the HTML spec of triggering the autofocus on page load, and not when the component mounts. React is more aggressive about this behavior.
This therefore gets rid of the
autoFocusprop which is ignored here, and focuses the input with an effect.Closes #119.