Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox: TypeError: window.$ is undefined #156

Closed
qsantos opened this issue Sep 12, 2019 · 6 comments
Closed

Firefox: TypeError: window.$ is undefined #156

qsantos opened this issue Sep 12, 2019 · 6 comments

Comments

@qsantos
Copy link

qsantos commented Sep 12, 2019

I get the following on Firefox 69.0 on Debian stable (10.1). The weird thing is that I was not able to reproduce the issue from a fresh Firefox profile, and neither disabling addons, allowing cookies, trackers and such, “forgotting the website” from the history tab, or using privacy browsing fixed the issue. I might have missed something else to try.

Capture d’écran_2019-09-12_20-43-54

Screenshot_2019-09-12 HN Search powered by Algolia

@Scrxtchy
Copy link

Still an issue on (dev) 70.0b6

@Haroenv
Copy link
Contributor

Haroenv commented Sep 16, 2019

I think this might happen because of this line @JonasBa

((window as any).$ as any).ajax({

@qsantos
Copy link
Author

qsantos commented Sep 16, 2019

I confirm that window.$ is not defined when I browse hn-search and type it in the developer console.

@JonasBa
Copy link
Contributor

JonasBa commented Sep 16, 2019

Thanks, fixing this asap now!

@JonasBa
Copy link
Contributor

JonasBa commented Sep 16, 2019

I merged a fix and will deploy this first thing tomorrow morning as we've just added some other changes in too. Thanks for reporting!

@JonasBa JonasBa closed this as completed Sep 17, 2019
@qsantos
Copy link
Author

qsantos commented Sep 17, 2019

I confirm that the issue is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants