Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Request #183

Open
leojkwan opened this issue Jul 24, 2021 · 0 comments
Open

Documentation Request #183

leojkwan opened this issue Jul 24, 2021 · 0 comments

Comments

@leojkwan
Copy link

I see that queryInputInteractor.connectSearcher has been extended with a new method:

@discardableResult func connectSearcher<Service: SearchService>(_ searcher: AbstractSearcher<Service>,
                                                                  searchTriggeringMode: SearchTriggeringMode = .searchAsYouType) -> TextualQuerySearcherConnection<Service> {
    let connection = TextualQuerySearcherConnection(interactor: self, searcher: searcher, searchTriggeringMode: searchTriggeringMode)
    connection.connect()
    return connection
  }

Is there any documentation on how to pass in an AbstractSearcher? I'm currently using the original implementation and I'm seeing a deprecation warning from:

@available(*, deprecated, message: "Use QueryInputInteractor.TextualQuerySearcherConnection")
  @discardableResult func connectSearcher<S: Searcher>(_ searcher: S,
                                                       searchTriggeringMode: SearchTriggeringMode = .searchAsYouType) -> SearcherConnection<S> {
    let connection = SearcherConnection(interactor: self, searcher: searcher, searchTriggeringMode: searchTriggeringMode)
    connection.connect()
    return connection
  }

I wish this SDK had better documentation, either on the website or in this repo, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant