Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchBox doesn't have icons in Safari #1968

Closed
Haroenv opened this issue Feb 10, 2017 · 2 comments
Closed

SearchBox doesn't have icons in Safari #1968

Haroenv opened this issue Feb 10, 2017 · 2 comments
Labels
Type: Bug

Comments

@Haroenv
Copy link
Contributor

Haroenv commented Feb 10, 2017 •
edited
Loading

Bug: What is the current behavior?

In Safari the icons of the search box don't show up

Visible in for example: https://community.algolia.com/instantsearch.js/react/storybook/?selectedKind=SearchBox&selectedStory=default&full=0&down=1&left=1&panelRight=1&downPanel=kadirahq%2Fstorybook-addon-knobs

screen shot 2017-02-10 at 17 49 01

Bug: What is the expected behavior?

The search box has buttons with icons like in Chrome

screen shot 2017-02-10 at 17 49 21

Bug: What browsers are impacted? Which versions?

All current Safari versions can't display svg inside a <button>, mve:

http://codepen.io/anon/pen/mRQMzW

What project are you opening an issue for?

  • react-instantsearch

What is the version you are using? Always use the latest one before opening a bug issue.

3.1.0
@vvo
Copy link
Contributor

vvo commented Feb 10, 2017

All current Safari versions can't display svg inside a , mve:

Thanks a lot you are the new safari detective! It's perfect :)

What about we use an <img src=svg instead?

@Haroenv
Copy link
Contributor Author

Haroenv commented Feb 11, 2017

I was missing the actual error and assuming svg was the problem, opening PR with the fix in a few minutes

Haroenv added a commit that referenced this issue Feb 11, 2017
@Haroenv
fix(SearchBox): Safari can only have <use> with xlinkHref
97fbac4 
Since React 0.14 it's allowed to use all svg features, and thus also those that are usuallly written
with a colon.

closes #1968
@Haroenv Haroenv mentioned this issue Feb 11, 2017
Merged
Haroenv added a commit that referenced this issue Feb 11, 2017
@Haroenv
fix(SearchBox): Safari can only have <use> with xlinkHref
18f90ee 
Since React 0.14 it's allowed to use all svg features, and thus also those that are usuallly written
with a colon.

closes #1968
@vvo vvo closed this as completed in #1970 Feb 12, 2017
vvo pushed a commit that referenced this issue Feb 12, 2017
@Haroenv @vvo
fix(SearchBox): Safari can only have <use> with xlinkHref (#1970)
7ab00bd 
Since React 0.14 it's allowed to use all svg features, and thus also those that are usuallly written
with a colon.

closes #1968
vvo pushed a commit that referenced this issue Feb 15, 2017
v3.2.0
4aa0fdc 
<a name="3.2.0"></a>
# [3.2.0](v3.1.0...v3.2.0) (2017-02-15)

### Bug Fixes

* **Configure:** use props a unique source of truth (#1967) ([9d53d86](9d53d86))
* **SearchBox:** Safari can only have <use> with xlinkHref (#1970) ([7ab00bd](7ab00bd)), closes [#1968](#1968)

### Features

* **MultiRange:** add an all range (#1959) ([a3dc950](a3dc950))

### BREAKING CHANGES

* MultiRange: - MultiRange/connectMultiRange: will add a "All" range to allow unselection of range without the usage of CurrentRefinements. This range can be either filtered or ramove via CSS if not needed. The label can be changed by using our translations system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vvo @Haroenv