fix(insights): fix the regression that it didn't send events with instantsearch.insights() #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tantsearch.insights()
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1812da7:
|
eunjae-lee
commented
Sep 21, 2020
src/lib/insights/listener.tsx
Outdated
| } else { | ||
| } | ||
|
|
||
| { |
There was a problem hiding this comment.
prop.sendEvent exists, so it always followed the first if branch. We should run them both.
There was a problem hiding this comment.
if we should run them both, you should probably remove the curly brace here and on line 72
ghost
requested review from
francoischalifour and
yannickcr
and removed request for
a team
yannickcr
approved these changes
Sep 21, 2020
Haroenv
requested changes
Sep 21, 2020
src/lib/insights/listener.tsx
Outdated
| } else { | ||
| } | ||
|
|
||
| { |
There was a problem hiding this comment.
if we should run them both, you should probably remove the curly brace here and on line 72
Haroenv
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the regression introduced since 4.8.0 where InstantSearch didn't send Insights events implemented with
instantsearch.insights()inhitsorinfiniteHitswidgets.Result
It sends events now.
Test
If you run this example ->, it will correctly send events when you click buttons. However if you change the version of InstantSearch to 4.8.0, it won't any more.