fix(configure): pass the latest state to onStateChange #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit da45143:
|
ghost
requested review from
francoischalifour and
shortcuts
and removed request for
a team
Haroenv
reviewed
Oct 29, 2020
Haroenv
reviewed
Oct 29, 2020
| import { createSearchClient } from '../../../test/mock/createSearchClient'; | ||
|
|
||
| describe('InstantSearch integration', () => { | ||
| it('renders', () => { |
There was a problem hiding this comment.
test name should be about configure & onStateChange
There was a problem hiding this comment.
oops, it was a temporary name. will fix it
|
You don't seem to have changed anything related to search state, how does this fix work? |
eunjae-lee
commented
Oct 29, 2020
| // Update original `widgetParams.searchParameters` to the new refined one | ||
| widgetParams.searchParameters = searchParameters; | ||
|
|
||
| // Trigger a search with the resolved search parameters | ||
| helper.setState(nextSearchParameters).search(); |
There was a problem hiding this comment.
When search happens, it will trigger onStateChange.
Before this change, the widgetParams was outdated at this point, now it's updated first, then the search is triggered.
Haroenv
approved these changes
Oct 30, 2020
|
Nice fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bug
configureconnector didn't pass the latest state toonStateChangewhenrefinehappened from it.fixes #4421
Result
onStateChangereceives the latest state. It's addressed in the integration test.