feat(sortBy): implement getRenderState and getWidgetRenderState
#4568
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a5b1030:
|
| }); | ||
|
|
||
| sortBy.init(createInitOptions({ helper })); | ||
| sortBy.getWidgetRenderState({ helper }).refine('index_desc'); |
There was a problem hiding this comment.
We used to have this pattern in tests:
const { refine } = renderFn.mock.calls[renderFn.mock.calls.length - 1][0];
refine('index_desc');It reads what's rendered from init call and get refine from there.
However, getting refine from getWidgetRenderState() also looks okay to me.
Just leaving this comment for Clément's information, and to see if others think differently.
There was a problem hiding this comment.
Thanks for the heads up!
You're right, I think I saw it in an other connector but now that we have getWidgetRenderState it might be easier to understand (at least for me 🤔 ).
There was a problem hiding this comment.
yes, I think using getWidgetRenderState is the way to go for new tests I think. It's okay if older tests still use refine from the calls, since the implementation should be the same anyway 👍
There was a problem hiding this comment.
Since render state is now public API it makes sense to use it—and it's such a relief!
There was a problem hiding this comment.
Looks good to me, but would like to get @yannickcr's opinion too
| @@ -103,7 +103,8 @@ export default function connectSortBy(renderFn, unmountFn = noop) { | |||
| return { | |||
| $$type: 'ais.sortBy', | |||
|
|
|||
| init({ helper, instantSearchInstance, parent }) { | |||
| init(initOptions) { | |||
| const { helper, instantSearchInstance, parent } = initOptions; | |||
| const currentIndex = helper.state.index; | |||
There was a problem hiding this comment.
We should get the current index from getWidgetRenderState otherwise we can get inconsistencies. We compute it twice at different spots here and we don't prevent the logic from differing.
…4568) * feat(sortBy): implement `getRenderState` and `getWidgetRenderState` * feat(sortBy): implement `getRenderState` and `getWidgetRenderState`
…4568) * feat(sortBy): implement `getRenderState` and `getWidgetRenderState` * feat(sortBy): implement `getRenderState` and `getWidgetRenderState`
This implements the
getRenderStateandgetWidgetRenderStatewidget lifecycle hooks insortBy.