refactor: rename all references to widgetOptions as widgetParams #4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
force-pushed
the
refactor/widgetParams
branch
from
7b1f219
to
aed837e
Compare
francoischalifour
approved these changes
Jan 14, 2021
Haroenv
force-pushed
the
refactor/widgetParams
branch
2 times, most recently
from
4cec96f
to
3b39b75
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 903e3e3:
|
The two terms were used interchangeably, mostly in comments and in function arguments. There's now only `TWidgetOptions` in the Widget generic, which isn't widgetParams BREAKING CHANGE: if you're using experimental-typescript and importing a type of the form `...WidgetOptions` (eg. replace `HitsWidgetOptions` with `HitsWidgetParams`)
Haroenv
force-pushed
the
refactor/widgetParams
branch
from
3b39b75
to
903e3e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two terms were used interchangeably, mostly in comments and in function arguments. There's now only
TWidgetOptionsin the Widget generic, which isn't widgetParamsBREAKING CHANGE: if you're using experimental-typescript and importing a type of the form
...WidgetOptions(eg. replaceHitsWidgetOptionswithHitsWidgetParams)