Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts): convert pagination widget and component #4765

Merged
merged 1 commit into from Jun 2, 2021

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented May 31, 2021

Summary

Converts pagination widget and Pagination component to TypeScript.

Ticket
DX-1704

@shortcuts shortcuts requested review from a team, tkrugg and Haroenv and removed request for a team May 31, 2021 09:23
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5fa4d4c:

Sandbox Source
InstantSearch.js Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, just a couple small questions!

src/components/Pagination/Pagination.tsx Show resolved Hide resolved
src/components/Pagination/Pagination.tsx Show resolved Hide resolved
src/components/Pagination/Pagination.tsx Show resolved Hide resolved
@shortcuts shortcuts merged commit 34eb950 into master Jun 2, 2021
@shortcuts shortcuts deleted the feat/ts-pagination branch June 2, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants