Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pagination]: Disabled links can still be clicked #974

Closed
pixelastic opened this issue Apr 11, 2016 · 0 comments
Closed

[pagination]: Disabled links can still be clicked #974

pixelastic opened this issue Apr 11, 2016 · 0 comments
Assignees
@pixelastic

Comments

@pixelastic
Copy link
Contributor

The way we disable pagination links currently is by adding a CSS class to them, and make them look greyed out. But in the DOM, they are still links and can be followed, leading the user to a page with no results.

image
image

I suggest we replace the a with span when they are disabled.
@pixelastic pixelastic mentioned this issue Apr 11, 2016
Merged
@pixelastic pixelastic self-assigned this Apr 11, 2016
@vvo vvo closed this as completed in 88b567f Apr 15, 2016
vvo pushed a commit that referenced this issue Apr 15, 2016
v1.4.4
b3cbdfe 
<a name="1.4.4"></a>
## [1.4.4](v1.4.3...v1.4.4) (2016-04-15)

### Bug Fixes

* **pagination:** Disabled pagination link can no longer be clicked ([88b567f](88b567f)), closes [#974](#974)
* **showMore:** hide showMore when no more facet values to show ([cc31b1a](cc31b1a))
@vvo vvo removed the in progress label Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelastic pixelastic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vvo @pixelastic