fix(insights): export Insights helper in the ESM build #4261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
tkrugg and
yannickcr
and removed request for
a team
yannickcr
approved these changes
Dec 16, 2019
Haroenv
approved these changes
Dec 16, 2019
Haroenv
added a commit
that referenced
this pull request
Dec 20, 2019
### Bug Fixes * **configureRelatedItems:** use `facetFilters` to exclude `obje… ([#4264](#4264)) ([9bc66cf](9bc66cf)) * **index:** fix warning for widgets sharing connectors ([#4260](#4260)) ([ec97b4a](ec97b4a)) * **insights:** export Insights helper in the ESM build ([#4261](#4261)) ([20649af](20649af)) * **insights:** move 'insightsClient not provided error' to wrapper level ([#4254](#4254)) ([15d38dd](15d38dd)) ### Features * **insights:** add hogan helper ([#4253](#4253)) ([85739d7](85739d7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never exported the
insightshelper in the ESM build, so the function was never usable. This fixes it by exporting theinsightshelper as we do forhighlightandsnippet.