fix(Pagination): fix and indicate when pagination is disabled

fixes #1938
algolia · Feb 6, 2017 · 5f20199 · 5f20199
1 parent 0971330
commit 5f20199
Show file tree

Hide file tree

Showing 4 changed files with 459 additions and 204 deletions.
diff --git a/packages/react-instantsearch/src/components/LinkList.js b/packages/react-instantsearch/src/components/LinkList.js
@@ -53,6 +53,7 @@ export default class LinkList extends Component {
               item.disabled && 'itemDisabled',
               item.modifier
             )}
+            disabled={item.disabled}
           >
             {item.disabled ?
               <span {...cx('itemLink', 'itemLinkDisabled')}>

diff --git a/packages/react-instantsearch/src/components/Pagination.js b/packages/react-instantsearch/src/components/Pagination.js
@@ -119,7 +119,6 @@ class Pagination extends Component {
       listComponent: ListComponent,
       ...otherProps
     } = this.props;
-
     const totalPages = Math.min(nbPages, maxPages);
     const lastPage = totalPages;
 
@@ -163,7 +162,7 @@ class Pagination extends Component {
       items.push({
         key: 'next',
         modifier: 'itemNext',
-        disabled: currentRefinement === lastPage,
+        disabled: currentRefinement === lastPage || lastPage <= 1,
         label: translate('next'),
         value: currentRefinement + 1,
         ariaLabel: translate('ariaNext'),
@@ -173,7 +172,7 @@ class Pagination extends Component {
       items.push({
         key: 'last',
         modifier: 'itemLast',
-        disabled: currentRefinement === lastPage,
+        disabled: currentRefinement === lastPage || lastPage <= 1,
         label: translate('last'),
         value: lastPage,
         ariaLabel: translate('ariaLast'),

diff --git a/packages/react-instantsearch/src/components/Pagination.test.js b/packages/react-instantsearch/src/components/Pagination.test.js
@@ -236,6 +236,22 @@ describe('Pagination', () => {
     expect(tree).toMatchSnapshot();
   });
 
+  it('disabled all button if no results', () => {
+    const tree = renderer.create(
+      <Pagination
+        {...REQ_PROPS}
+        maxPages={Number.POSITIVE_INFINITY}
+        showLast
+        showFirst
+        showNext
+        showPrevious
+        nbPages={0}
+        currentRefinement={1}
+      />
+    ).toJSON();
+    expect(tree).toMatchSnapshot();
+  });
+
   it('refines its value when clicking on a page link', () => {
     const refine = jest.fn();
     const wrapper = mount(