feat(index): merge ruleContexts search parameter (#3944)

algolia · Oct 23, 2019 · e94752d · e94752d
1 parent bcfa634
commit e94752d
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 1 deletion.
diff --git a/src/lib/utils/__tests__/mergeSearchParameters-test.ts b/src/lib/utils/__tests__/mergeSearchParameters-test.ts
@@ -381,4 +381,31 @@ describe('mergeSearchParameters', () => {
       })
     );
   });
+
+  it('merges and dedupes `ruleContexts` parameters', () => {
+    const actual = merge(
+      algoliasearchHelper.SearchParameters.make({
+        ruleContexts: ['ais-genre-comedy'],
+      }),
+      algoliasearchHelper.SearchParameters.make({
+        ruleContexts: ['ais-genre-thriller', 'ais-genre-comedy'],
+      }),
+      algoliasearchHelper.SearchParameters.make({
+        ruleContexts: ['ais-rating-4'],
+      }),
+      algoliasearchHelper.SearchParameters.make({
+        ruleContexts: [],
+      })
+    );
+
+    expect(actual).toEqual(
+      algoliasearchHelper.SearchParameters.make({
+        ruleContexts: [
+          'ais-genre-comedy',
+          'ais-genre-thriller',
+          'ais-rating-4',
+        ],
+      })
+    );
+  });
 });
diff --git a/src/lib/utils/mergeSearchParameters.ts b/src/lib/utils/mergeSearchParameters.ts
@@ -1,5 +1,6 @@
 import { SearchParameters } from 'algoliasearch-helper';
 import findIndex from './findIndex';
+import uniq from './uniq';
 
 type Merger = (
   left: SearchParameters,
@@ -17,6 +18,7 @@ const mergeWithRest: Merger = (left, right) => {
     tagRefinements,
     hierarchicalFacets,
     hierarchicalFacetsRefinements,
+    ruleContexts,
     ...rest
   } = right;
 
@@ -103,6 +105,23 @@ const mergeHierarchicalFacetsRefinements: Merger = (left, right) =>
     },
   });
 
+const mergeRuleContexts: Merger = (left, right) => {
+  const ruleContexts: string[] = uniq(
+    ([] as any)
+      .concat(left.ruleContexts)
+      .concat(right.ruleContexts)
+      .filter(Boolean)
+  );
+
+  if (ruleContexts.length > 0) {
+    return left.setQueryParameters({
+      ruleContexts,
+    });
+  }
+
+  return left;
+};
+
 const merge = (...parameters: SearchParameters[]): SearchParameters =>
   parameters.reduce((left, right) => {
     const hierarchicalFacetsRefinementsMerged = mergeHierarchicalFacetsRefinements(
@@ -137,7 +156,11 @@ const merge = (...parameters: SearchParameters[]): SearchParameters =>
       facetRefinementsMerged,
       right
     );
-    const facetsMerged = mergeFacets(disjunctiveFacetsMerged, right);
+    const ruleContextsMerged = mergeRuleContexts(
+      disjunctiveFacetsMerged,
+      right
+    );
+    const facetsMerged = mergeFacets(ruleContextsMerged, right);
 
     return mergeWithRest(facetsMerged, right);
   });