Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-instantsearch release 🔙🔛🔝🔜 #1312

Closed
12 of 26 tasks
vvo opened this issue Sep 20, 2016 · 2 comments
Closed
12 of 26 tasks

react-instantsearch release 🔙🔛🔝🔜 #1312

vvo opened this issue Sep 20, 2016 · 2 comments
Assignees

Comments

@vvo
Copy link
Contributor

vvo commented Sep 20, 2016

Here are the necessary things to fix before we can claim a release. Put your name next to one you wanna do. Create an issue if necessary, otherwise just do it.

API

We are getting there, nothing much left.

Website

Docs

Docs must be 100% accurate, clear and to the point. We have some areas to fix.

  • add docsearch
  • Left sidebar is behaving badly Left navigation sidebar is not behaving well #1671
  • Ensure react-instantsearch website always link to the v2 branch as for viewing code
  • Ensure relative links are always working when website deployed to production (/instantsearch.js/react) Fix all broken links in the documentation #1639 @vvo
  • Ensure we inject and use the version of react-instantsearch react-instantsearch-theme-algolia in the website so that links to specific versions are always up to date (like the CSS file) Update styling guide to automatically inline current theme version to download #1641
  • (Marie) Ensure places we speak about "Component(s)" in the documentation are relevant. Otherwise it should be Widget (i.e. NO SearchBox component, YES SearchBox widget). Only <InstantSearch> can be called a component. Widgets are connected components.
  • (Marie) getProvidedProps(props, state, search, meta) should always be getProvidedProps(props, searchState, searchResults, metadata). We need to be very precise about what we talk. Both code and documentation should always refer to searchState instead of InstantSearch state or state. It should be less confusing for users to always have a clear name to use.
  • Ensure every connector has a precise documentation, in particular on currentRefinement and refine descriptions. We sometime have vague descriptions or erroneous ones, we need to be precise. (example: connectSearchBox). If we have a refine method, we need to explain how to call it, what are the argument. Maybe we could just add one example per connector (very very simple one), and put it at the top. One simple example speaks a lot more for connectors maybe than the vague props.
  • Read, re-read every documentation as if you were a new user. Start from getting started, do it, read the guide, follow it, read API descriptions. This takes time but will be worth it.
  • Everywhere we speak about an actual token to be used in JSX (Like the "InstantSearch component"), we should write it as JSX, like the "<InstantSearch> component". For ease of reading.
  • @vvo Ask a native english speaker to proof read the documentation once last beta is released
  • Actually release the non beta version, right before we go live

Right after release:

  • Announce react-instantsearch on instantsearch.js main README (develop branch)
    Link to the website, link to the code, top of the file. GOAL: be transparent
  • Put a banner (need a banner, cc @sebnvzt) on instantsearch.js website
  • Put a banner on Algolia.com website, or at least find a place where mentioning react-instantsearch makes sense and helps users
@vvo vvo self-assigned this Oct 21, 2016
@vvo vvo added this to the react-instantsearch first release milestone Oct 21, 2016
@vvo vvo changed the title react-instantsearch release: mandatory changes react-instantsearch release 🔙🔛🔝🔜 Oct 21, 2016
@vvo
Copy link
Contributor Author

vvo commented Oct 21, 2016

Locking this, we are using it as a single point of entry for any work related on react-instantsearch. You can still open discussion here or privately.

@algolia algolia locked and limited conversation to collaborators Oct 21, 2016
@vvo vvo removed this from the react-instantsearch first release milestone Nov 25, 2016
@vvo vvo removed the Type: Refactor label Dec 6, 2016
@vvo vvo closed this as completed Dec 13, 2016
@vvo
Copy link
Contributor Author

vvo commented Dec 13, 2016

🔥

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant